Hi @Babbles,
This Github Issue might help: https://github.com/mattermost/mattermost-server/issues/9037.
Hi @Babbles,
This Github Issue might help: https://github.com/mattermost/mattermost-server/issues/9037.
Hey @gubbins.
Interesting find. I would’ve said that it’s just a bug in marked.js, but it also occurs with the custom autolinking we’ve added to commonmark.js in the mobile app as well. I’m actually surprised the server’s Markdown parser handles it correctly, but I’m pretty sure that I just translated that code from GitHub’s Markdown parser instead of trying to write a completely custom version like the apps use.
I spent a bit of time comparing the code used on the server with our custom marked and commonmark versions, and it looks like the difference is that the apps treat curly brackets, as well as some other characters, as punctuation that should be trimmed from the end of the link, while the server does not. Fixing that should actually be fairly easy in that case, since I expected it to be caused by something more complicated. Great catch that the server handles it correctly or else we might not have noticed that.
I’ve filed MM-13837 to look into this further. Also, since you were comfortable digging around in the markdown parser on the server, I can gladly point you into the right direction if you’d like to help out by fixing it on the web and mobile apps.
Thanks @hmhealey. I have almost zero JavaScript knowledge right now so I doubt I will be much use on the webapp side but maybe I will take a look one weekend…
Hi @codinghorror,
I forwarded your feedback to our team and it sounds like there have been some changes made recently that might be able to support larger max image dimensions. The Jira ticket referenced above has been re-opened and re-triaged for further discussion.
Earlier there were security concerns that we would have to load the image into memory to generate a thumbnail/preview, and large images take up a lot of memory. It’s also possible to make an image that’s small as a file, but when we read it into memory, it has massive dimensions which is why those max dimensions were added in the first place. For example, the sample file I had been using that then was a 5MB PNG file that would take up 116GB of memory when fully read into memory.
We need some max dimensions, but we could certainly look at increasing them. One of our developers did a bunch of work recently on improving the memory usage of file uploads, so he might have a better idea of how large we should be able to go. The current max dimensions support an image that takes 36MB when read into memory, so that’s already quite large.
The dev who is working on relaxing the file size constraints for non-image files has a separate ticket open here: https://mattermost.atlassian.net/browse/MM-10188.
Images currently require to be decoded for 2 use cases:
Hello all,
A year ago I have developed appear.in integration to work similar like with Slack using slash commands. Today I have upgraded the plugin to support Jitsi, also it is added https support.
Integration app is written in NodeJS and it is located on https://github.com/zarej/Mattermost-Integration-with-Appear.in
A week ago one of my DNS servers crahshed. For a few days the mattermost server couldn’t resolve the push notification server. I changed the DNS to google for now and i can now resolve and use curl to get to push-test.mattermost.com. Every time i send a test message the log shows
app/notification_push.go:280",“msg”:“Device push reported as error for UserId=eu7d75esd7dgtfuqpmx517rk8a SessionId=unm4n1fjutfbubbqrsat3mb7yo message=Post http://push-test dot mattermost dot com/api/v1/send_push: dial tcp: i/o timeout”,“user_id”:“eu7d75esd7dgtfuqpmx517rk8a”}
How can we reproduce the issue (what version are you using?)
I updated to version 5.7 in an attempt to correct but that didn’t help.
What did you see happen? Please include relevant error messages and/or screenshots.
Error message in details.
Hello, its my first post here.
Mattermost 5.7.0, internal IP, no domain.
Even though integration with jenkins (same LAN, docker container) does work, i cant set icon/avatar for notifications. I set up icon field in jenkins global settings with jenkins PNG icon. Test message changed from icon=null to icon=’’. I tried to set it manually in pipleline …
mattermostSend icon: 'https://jenkins.io/images/logos/jenkins/256.png', color: "danger", message: "Some error"
Doesnt work either. Notifications comes with first user name (admin) and icon.
This works now. Thanks for looking into it.
Hi @amy.blais
I tried it with 5.5.1 version and also latest master. The relevant code for sending user_added is here https://github.com/mattermost/mattermost-server/blame/ce2c7110d3db836790f90fc63968b68f14a9f516/app/channel.go#L831 and based on blame it seems it did not change in 2 years and as you can see only ‘channel.Id’ is filled there for the event broadcast. I did not find any other usage of the WEBSOCKET_EVENT_USER_ADDED event in the code. Is it possible there is some other event I should be looking for?
Greetings
We have a problem using MM. After installing the application and connecting to the server, after a while the loading ends with a white screen.
We reinstall the application, but after 2-3 days the problem returns. Found this problem with ios and android. Any idea how to fix this?
Hello,
I realized that everyone could ban the administrator from private or public channels. Is it possible to change this?
Thank you in advance.
Facing same issue from past few hours
Before that it was working fine and no changes have been done since few months.
My Mattermost Version is 5.3.1
My Push notification server is http://push-test.mattermost.com
We are also facing the problem.
Mattermost Version: 5.7.0
Database Schema Version: 5.7.0
Database: mysql
This appears to have started a few days ago.
(post withdrawn by author, will be automatically deleted in 24 hours unless flagged)
Hi @zarej,
That is awesome! If you haven’t already, would you be open to filling out this form: https://spinpunch.wufoo.com/forms/mattermost-integrations-and-installers/?
@jbaird I have the same issue
curl -l push-test.mattermost.com
gives me below output
<html>
<head><title>301 Moved Permanently</title></head>
<body bgcolor="white">
<center><h1>301 Moved Permanently</h1></center>
</body>
</html>
@amy.blais
Is there any limit when we are using TPNS ( push-test.mattermost.com ) in team edition ?
Seems recently the push notifications seemed to have stopped.
The test pushsystem is now https://
The test pushsystem is now https://
Thanks @JtheBAB
This resolved the issue. The default URL was not working as it was pre-applied when we use default TPNS. I guess this was changed 1 day ago in the backend.