Quantcast
Channel: Mattermost Discussion Forums - Latest posts
Viewing all articles
Browse latest Browse all 25778

Email Notifications - broken email content encoding and empty 'Sender' field

$
0
0

Just checked the github repository and the issue should be fixed in commit 830c6b3f:

commit 830c6b3f1ebdfc38ca8ee0e6c672301fbe884e21
Author: Melvi Ts layzerar@gmail.com
Date: Thu Oct 15 21:17:52 2015 +0800

Fix email encoding issue

So we just need a new release (+gitlab release).

@kmazurek do you run standalone instance of mattermost and are you able to test the fix?

$ git diff 830c6b3f~..830c6b3f
diff --git a/utils/mail.go b/utils/mail.go
index c91c15a..07a79ee 100644
--- a/utils/mail.go
+++ b/utils/mail.go
@@ -6,15 +6,22 @@ package utils
 import (
        l4g "code.google.com/p/log4go"
        "crypto/tls"
+       "encoding/base64"
        "fmt"
        "github.com/mattermost/platform/model"
-       "html"
        "net"
        "net/mail"
        "net/smtp"
        "time"
 )
 
+func encodeRFC2047Word(s string) string {
+       // TODO: use `mime.BEncoding.Encode` instead when `go` >= 1.5
+       // return mime.BEncoding.Encode("utf-8", s)
+       dst := base64.StdEncoding.EncodeToString([]byte(s))
+       return "=?utf-8?b?" + dst + "?="
+}
+
 func connectToSMTPServer(config *model.Config) (net.Conn, *model.AppError) {
        var conn net.Conn
        var err error
@@ -102,9 +109,10 @@ func SendMailUsingConfig(to, subject, body string, config *model.Config) *model.
        headers := make(map[string]string)
        headers["From"] = fromMail.String()
        headers["To"] = toMail.String()
-       headers["Subject"] = html.UnescapeString(subject)
+       headers["Subject"] = encodeRFC2047Word(subject)
        headers["MIME-version"] = "1.0"
-       headers["Content-Type"] = "text/html"
+       headers["Content-Type"] = "text/html; charset=\"utf-8\""
+       headers["Content-Transfer-Encoding"] = "8bit"
        headers["Date"] = time.Now().Format(time.RFC1123Z)
 
        message := ""

Viewing all articles
Browse latest Browse all 25778

Trending Articles



<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>